fix: don't pass temp_path through metadata batch

The temp file is deleted after each loop iteration (in the finally
block), but the metadata batch is flushed later — so the temp_path
stored in the batch points to a deleted file.

Fix: use temp_path only for artifact_to_python_content_data (avoids
one S3 read per package). The metadata batch falls back to
artifact_to_metadata_artifact's original behavior for the second read.
Combined with BULK_SIZE=250, this is still a major memory improvement.

JIRA: PULP-1573

Author: decko

pulp_python/app/tasks/repair.py

@@ -132,7 +132,6 @@ def repair_metadata(content: QuerySet[PythonPackageContent]) -> tuple[int, set[s
                     main_artifact,
                     metadata_batch,
                     pkgs_metadata_not_repaired,
-                    temp_path=temp_path,
                 )
                 total_repaired += update_package_if_needed(
                     package, new_data, batch, set_of_update_fields
@@ -249,7 +248,6 @@ def update_metadata_artifact_if_needed(
     main_artifact: Artifact,
     metadata_batch: list[tuple],
     pkgs_metadata_not_repaired: set[str],
-    temp_path: str | None = None,
 ) -> int:
     """
     Repairs metadata artifacts for wheel packages by creating missing metadata artifacts
@@ -262,7 +260,6 @@ def update_metadata_artifact_if_needed(
         main_artifact: The main package artifact used to generate metadata.
         metadata_batch: List of tuples for batch processing (updated in-place).
         pkgs_metadata_not_repaired: Set of package PKs that failed repair (updated in-place).
-        temp_path: Path to already-extracted temp wheel file, avoids re-reading from S3.
 
     Returns:
         Number of repaired metadata artifacts (only when batch is flushed at BULK_SIZE).
@@ -277,13 +274,13 @@ def update_metadata_artifact_if_needed(
 
     # Create missing
     if not cas:
-        metadata_batch.append((package, main_artifact, temp_path))
+        metadata_batch.append((package, main_artifact))
     # Fix existing
     elif new_metadata_sha256 != original_metadata_sha256:
         ca = cas.first()
         metadata_artifact = ca.artifact
         if metadata_artifact is None or (metadata_artifact.sha256 != new_metadata_sha256):
-            metadata_batch.append((package, main_artifact, temp_path))
+            metadata_batch.append((package, main_artifact))
 
     if len(metadata_batch) == BULK_SIZE:
         not_repaired = _process_metadata_batch(metadata_batch)
@@ -300,18 +297,16 @@ def _process_metadata_batch(metadata_batch: list[tuple]) -> set[str]:
     and their corresponding ContentArtifacts.
 
     Args:
-        metadata_batch: List of (package, main_artifact, temp_path) tuples.
+        metadata_batch: List of (package, main_artifact) tuples.
 
     Returns:
         Set of package PKs for which metadata artifacts could not be created.
     """
     not_repaired = set()
     content_artifacts = []
 
-    for package, main_artifact, temp_path in metadata_batch:
-        metadata_artifact = artifact_to_metadata_artifact(
-            package.filename, main_artifact, temp_path=temp_path
-        )
+    for package, main_artifact in metadata_batch:
+        metadata_artifact = artifact_to_metadata_artifact(package.filename, main_artifact)
         if metadata_artifact:
             ca = ContentArtifact(
                 artifact=metadata_artifact,