tmp: revert

Author: jobselko

pulp_python/app/models.py

@@ -456,6 +456,8 @@ def check_blocklist_for_packages(self, packages):
                 "Blocklisted packages cannot be added to this repository: "
                 "{}".format(", ".join(blocked))
             )
+        if False:
+            raise ValidationError()
 
 
 class PythonBlocklistEntry(BaseModel):

pulp_python/tests/functional/utils.py

@@ -67,8 +67,7 @@ def ensure_simple(
     how would one know that it's there?*
     """
 
-    def explore_links(page_url, page_name, links_found):
-        msgs = ""
+    def explore_links(page_url, page_name, links_found, msgs):
         legit_found_links = []
         page_content = requests.get(page_url).text
         page = html.fromstring(page_content)
@@ -92,18 +91,15 @@ def explore_links(page_url, page_name, links_found):
                     msgs += f"\nFound {page_name} link without href {link.text}"
             else:
                 msgs += f"\nFound extra {page_name} link {link.text}"
-        return legit_found_links, msgs
+        return legit_found_links
 
     packages_found = {name: False for name in packages.keys()}
     releases_found = {name: False for releases in packages.values() for name in releases}
-    found_release_links, msgs = explore_links(simple_url, "simple", packages_found)
+    msgs = ""
+    found_release_links = explore_links(simple_url, "simple", packages_found, msgs)
     dl_links = []
     for rel_link in found_release_links:
-        new_links, new_msgs = explore_links(
-            urljoin(simple_url, rel_link), "release", releases_found
-        )
-        dl_links += new_links
-        msgs += new_msgs
+        dl_links += explore_links(urljoin(simple_url, rel_link), "release", releases_found, msgs)
     for dl_link in dl_links:
         package_link, _, sha = dl_link.partition("#sha256=")
         if len(sha) != 64: