Conversation
aKlimau
force-pushed
the
add-pulp-exceptions
branch
8 times, most recently
from
5ebcc3a to
88bc331
Compare
| Stage, | ||
| ) | ||
|
|
||
| from pulp_python.app.exceptions import UnsupportedProtocolError |
There was a problem hiding this comment.
Why do we need this? I do not remember that is was reported by CI. It also looks like sth that should be in pulpcore.
There was a problem hiding this comment.
Can we replace UnsupportedProtocolError by SyncError?
| Raised when provenance verification fails. | ||
| """ | ||
|
|
||
| error_code = "PLPY0001" |
There was a problem hiding this comment.
Do we already have a naming convention for plugins? Pulpcore uses "PLP", this introduces "PLPY"
There was a problem hiding this comment.
We don't have a strict convention for plugins, but some plugins have already created exceptions with codes, so until we have a reason to make it all stricter we will go with it.
There was a problem hiding this comment.
The name should be PYT0001 (agreed in the core team mtg)
aKlimau
force-pushed
the
add-pulp-exceptions
branch
4 times, most recently
from
655383c to
02b7c62
Compare
Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
02b7c62 to
d0d8812
Compare
There was a problem hiding this comment.
fetch_json_release_metadata from utils.py can also raise an exception, this is called within the repair task
| raise serializers.ValidationError( | ||
| _( | ||
| "Extension on {} is not a valid python extension " | ||
| "(.whl, .exe, .egg, .tar.gz, .tar.bz2, .zip)" | ||
| ).format(filename) | ||
| ) |
There was a problem hiding this comment.
This can be replaced by InvalidPythonExtensionError
2 participants
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com
📜 Checklist