Remove dead code

Author: dralley

pulpcore/app/replica.py

@@ -174,17 +174,11 @@ def distribution_extra_fields(self, repository, upstream_distribution):
         """
         Return the fields that need to be updated/cleared on distributions for idempotence.
 
-        Note: repository_version is computed here but filtered out for updates/creates.
-        It will be set atomically in finalize_replication after sync completes.
+        Note: repository_version is NOT included here. It is set atomically in
+        finalize_replication after all syncs complete.
         """
-        latest = repository.latest_version()
-        if latest:
-            repo_version_href = get_url(repository) + "versions/{}/".format(latest.number)
-        else:
-            repo_version_href = None
         return {
             "repository": None,
-            "repository_version": repo_version_href,
             "publication": None,
             "base_path": upstream_distribution["base_path"],
         }
@@ -198,32 +192,26 @@ def create_or_update_distribution(self, repository, upstream_distribution):
             )
             if not self._is_managed(distro):
                 return None
-            # Don't update repository_version here — that happens atomically in
-            # finalize_replication after all syncs complete.
-            # Do clear repository and publication so they don't conflict.
-            update_data = {k: v for k, v in distribution_data.items() if k != "repository_version"}
-            needs_update = self.needs_update(update_data, distro)
+            # Clear repository and publication so they don't conflict when
+            # finalize_replication sets repository_version atomically.
+            needs_update = self.needs_update(distribution_data, distro)
             if needs_update:
-                # Update the distribution
                 dispatch(
                     ageneral_update,
                     task_group=self.task_group,
                     shared_resources=[repository, self.server],
                     exclusive_resources=self.distros_uris,
                     args=(distro.pk, self.app_label, self.distribution_serializer_name),
                     kwargs={
-                        "data": update_data,
+                        "data": distribution_data,
                         "partial": True,
                     },
                 )
         except self.distribution_model_cls.DoesNotExist:
-            # Dispatch a task to create the distribution
-            # Don't set repository_version for new distributions - it will be set in
-            # finalize_replication after sync completes.
+            # Don't set repository or publication for new distributions —
+            # repository_version will be set in finalize_replication after sync completes.
             create_data = {
-                k: v
-                for k, v in distribution_data.items()
-                if k not in ("repository_version", "repository", "publication")
+                k: v for k, v in distribution_data.items() if k not in ("repository", "publication")
             }
             create_data["name"] = upstream_distribution["name"]
             create_data["pulp_labels"] = distribution_data["pulp_labels"]

pulpcore/tests/functional/api/test_replication.py

@@ -195,7 +195,7 @@ def test_replication_with_repo_based_distribution(
     repo = file_repository_factory(pulp_domain=source_domain.name, autopublish=True)
     sync_data = file_bindings.module.RepositorySyncURL(remote=remote.pulp_href, mirror=True)
     monitor_task(file_bindings.RepositoriesFileApi.sync(repo.pulp_href, sync_data).task)
-    _distro = file_distribution_factory(pulp_domain=source_domain.name, repository=repo.pulp_href)
+    _ = file_distribution_factory(pulp_domain=source_domain.name, repository=repo.pulp_href)
 
     # Replicate
     replica_domain = domain_factory()