Fix RepositoryVersion.remove_content using wrong queryset for lazy content

The remove_content method was incorrectly using the unfiltered `content`
queryset instead of `to_remove` when deleting or marking
RepositoryContent entries as removed. This caused all content to be
removed from the repository version rather than only the specified lazy
content.

Fixes: #7851

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 2 people

CHANGES/7851.bugfix

@@ -0,0 +1 @@
+Fixed `RepositoryVersion.remove_content` failing when the queryset is derived from `self.content` and the repository version contains >= 65,535 content items. The lazy queryset was re-evaluated after `content_ids` was already updated, causing `RepositoryContent` entries to be left orphaned.

pulpcore/app/models/repository.py

@@ -1223,10 +1223,6 @@ def remove_content(self, content):
         content_ids = set(self.content_ids)
         to_remove = set(content.values_list("pk", flat=True))
         with transaction.atomic():
-            if to_remove:
-                self.content_ids = list(content_ids - to_remove)
-                self.save()
-
             # Normalize representation if content has already been added in this version.
             # Undo addition by deleting the RepositoryContent.
             RepositoryContent.objects.filter(
@@ -1241,6 +1237,10 @@ def remove_content(self, content):
             )
             q_set.update(version_removed=self)
 
+            if to_remove:
+                self.content_ids = list(content_ids - to_remove)
+                self.save()
+
     def set_content(self, content):
         """
         Sets the repo version content by calling remove_content() then add_content().