Fix pulp_hashlib.new() on FIPS systems#7438
Closed
kush-gupt wants to merge 1 commit into
Closed
Conversation
Pass usedforsecurity=False to hashlib.new() since all hashes produced by this wrapper are used for content addressing (storage paths, dedup, manifest IDs), never for cryptographic security. closes pulp#7434 Signed-off-by: Kush Gupta <kushalgupta@gmail.com> Made-with: Cursor
3 tasks
Contributor
|
I don't think this change is necessary. I think the Satellite RPMs ship a patch that sets That said, it's been a very long time since I worked on this so maybe things have changed. |
Author
|
Closing this — @daviddavis is right, Satellite already ships a downstream patch for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usedforsecurity=Falsetopulp_hashlib.new()so FIPS-disallowed algorithms (e.g. md5, sha1) used for content addressing no longer raiseUnsupportedDigestmodError.setdefaultpreserves any explicitusedforsecurity=Truea caller might pass.UnsupportedDigestmodErrorbefore the fix, HTTP 201 after.Checklist
closes #7434
See also: pulp/pulp_container#2256
Made with Cursor