Fix dynaconf's django integration#7892
Conversation
6b2ed2d to
6a940f2
Compare
| file=settings.DB_ENCRYPTION_KEY, err=ex | ||
| ) | ||
| ) | ||
| return {} |
There was a problem hiding this comment.
In general, if on setting depend on another setting, it should be inside a hook, and not after the dynaconf instantiation. For instance, FORBIDDEN_CHECKSUMS was not picking up the user provided ALLOWED_CONTENT_CHECKSUMS.
There was a problem hiding this comment.
Didn't realize this was a PR on 3.115 - we need this on main, please
There was a problem hiding this comment.
Yeah, I should have opened against main and then added the backport label.
Was caught in moment.
41ad4d4 to
c22c750
Compare
Thre should be no settings activity after dyanconf's instantiation. Assisted-by: Claude (Claude Code)
c22c750 to
0a06d30
Compare
ggainey
left a comment
There was a problem hiding this comment.
Great catch - and much cleaner than we were!
Backport to 3.115: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 3f395c1 on top of patchback/backports/3.115/3f395c1d25effcab0a5a69cc2d96b52cf559f42f/pr-7892 Backporting merged PR #7892 into 3.115
🤖 @patchback |
Can't backport to 3.115 when it's on 3.115 - who knew?!? :) |
Apparently it works if we follow the docs instructions to not set anything after the integration code. I'm probably the number one to blame on not having taken that seriously enough 🙈
Test PR: pulp/pulp_rpm#4521
📜 Checklist
See: Pull Request Walkthrough