Skip to content

plan(v0.26): triage serve-filtering (#674) + release-vs-variant (#673)#686

Merged
avrabe merged 1 commit into
mainfrom
plan/v0.26-triage
Jul 11, 2026
Merged

plan(v0.26): triage serve-filtering (#674) + release-vs-variant (#673)#686
avrabe merged 1 commit into
mainfrom
plan/v0.26-triage

Conversation

@avrabe

@avrabe avrabe commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Triages the two actionable open feature requests into v0.26 as proposed requirements (planning lives in rivet, per release-planning), and corrects one stale status.

rivet validate → PASS, rivet docs check → 0 violations.

Refs: REQ-253, REQ-254, REQ-251

🤖 Generated with Claude Code

…; mark REQ-251 done

Triages the two actionable open feature requests into v0.26 as proposed
requirements (the plan lives in rivet, not just the issue tracker):

- REQ-253 (#674): richer serve filtering — reuse the existing s-expr filter
  and/or the gluesql `rivet sql` facade rather than a serve-only filter
  language.
- REQ-254 (#673): check a release against variant scope — design-first
  (needs a DD on release ∩ variant semantics before implementation).

Also corrects REQ-251 (serializer field-drop guard): proposed → implemented,
release v0.25.0 — the compile-time exhaustiveness guard shipped as #634.

Confirmed with `rivet validate` (Result: PASS) and `rivet docs check`
(0 violations).

Refs: REQ-253, REQ-254, REQ-251, FEAT-001

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: ea6234e Previous: f3c0e93 Ratio
store_insert/10000 20574820 ns/iter (± 1767800) 12136780 ns/iter (± 298062) 1.70
link_graph_build/10000 58730114 ns/iter (± 6655538) 23467162 ns/iter (± 397068) 2.50
diff/10000 12658788 ns/iter (± 1143474) 8454617 ns/iter (± 760072) 1.50

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions

Copy link
Copy Markdown

📐 Rivet artifact delta

Change Count
Added 2
Removed 0
Modified 1
Downstream impacted (depth ≤ 5) 0

Graph

graph LR
  REQ_251["REQ-251"]:::modified
  REQ_253["REQ-253"]:::added
  REQ_254["REQ-254"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Loading
Added
  • REQ-253
  • REQ-254
Modified
ID Changes
REQ-251

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-686download from the workflow run.

Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.

@avrabe
avrabe merged commit 9d105e1 into main Jul 11, 2026
28 of 29 checks passed
@avrabe
avrabe deleted the plan/v0.26-triage branch July 11, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant