plan(v0.26): triage serve-filtering (#674) + release-vs-variant (#673)#686
Merged
Conversation
…; mark REQ-251 done Triages the two actionable open feature requests into v0.26 as proposed requirements (the plan lives in rivet, not just the issue tracker): - REQ-253 (#674): richer serve filtering — reuse the existing s-expr filter and/or the gluesql `rivet sql` facade rather than a serve-only filter language. - REQ-254 (#673): check a release against variant scope — design-first (needs a DD on release ∩ variant semantics before implementation). Also corrects REQ-251 (serializer field-drop guard): proposed → implemented, release v0.25.0 — the compile-time exhaustiveness guard shipped as #634. Confirmed with `rivet validate` (Result: PASS) and `rivet docs check` (0 violations). Refs: REQ-253, REQ-254, REQ-251, FEAT-001
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ea6234e | Previous: f3c0e93 | Ratio |
|---|---|---|---|
store_insert/10000 |
20574820 ns/iter (± 1767800) |
12136780 ns/iter (± 298062) |
1.70 |
link_graph_build/10000 |
58730114 ns/iter (± 6655538) |
23467162 ns/iter (± 397068) |
2.50 |
diff/10000 |
12658788 ns/iter (± 1143474) |
8454617 ns/iter (± 760072) |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
📐 Rivet artifact delta
Graphgraph LR
REQ_251["REQ-251"]:::modified
REQ_253["REQ-253"]:::added
REQ_254["REQ-254"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Modified
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triages the two actionable open feature requests into v0.26 as
proposedrequirements (planning lives in rivet, per release-planning), and corrects one stale status.rivet sqlfacade, not a serve-only filter language.rivet validate→ PASS,rivet docs check→ 0 violations.Refs: REQ-253, REQ-254, REQ-251
🤖 Generated with Claude Code