Commit eaa5c6a
fix(ci): harden cargo-deny step (remove || true, add step names) (#107)
Issue #103 was largely closed in PR #106 (smithy runner migration), which
replaced EmbarkStudios/cargo-deny-action@v2 with rustup + direct
`cargo install --locked` + `cargo deny check`. This commit cleans up
two residual defects in that step:
1. The install command was wrapped in `|| true`, so an install
failure was silently swallowed and the next step would fail with
a confusing "command not found". Drop the `|| true` so install
failure fails the job loudly with a clear error.
2. Add explicit `name:` labels to the install / check steps so CI
logs are readable.
3. Rewrite the rationale comment to reference the rust-toolchain.toml
/ musl interaction (the actual root cause of #103) with the
smithy rootless-container note as secondary context.
The duplicate `thiserror` 1.x/2.x versions cargo-deny will likely
re-flag once it actually runs cleanly are out of scope here; will
file a follow-up if it surfaces.
Fixes: #103
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 90d0f48 commit eaa5c6a
1 file changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
| |||
0 commit comments