Skip to content

Commit eaa5c6a

Browse files
avrabeclaude
andauthored
fix(ci): harden cargo-deny step (remove || true, add step names) (#107)
Issue #103 was largely closed in PR #106 (smithy runner migration), which replaced EmbarkStudios/cargo-deny-action@v2 with rustup + direct `cargo install --locked` + `cargo deny check`. This commit cleans up two residual defects in that step: 1. The install command was wrapped in `|| true`, so an install failure was silently swallowed and the next step would fail with a confusing "command not found". Drop the `|| true` so install failure fails the job loudly with a clear error. 2. Add explicit `name:` labels to the install / check steps so CI logs are readable. 3. Rewrite the rationale comment to reference the rust-toolchain.toml / musl interaction (the actual root cause of #103) with the smithy rootless-container note as secondary context. The duplicate `thiserror` 1.x/2.x versions cargo-deny will likely re-flag once it actually runs cleanly are out of scope here; will file a follow-up if it surfaces. Fixes: #103 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 90d0f48 commit eaa5c6a

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

.github/workflows/supply-chain.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,16 @@ jobs:
6464
steps:
6565
- uses: actions/checkout@v4
6666
- uses: dtolnay/rust-toolchain@stable
67-
# EmbarkStudios/cargo-deny-action@v2 launches a rootless container which
68-
# fails on smithy (newuidmap is setuid + NoNewPrivileges=true on the
69-
# runner unit). Direct install + invocation, per smithy migration playbook.
70-
# bans/licenses/sources only (advisories handled by cargo-audit job).
71-
- run: cargo install cargo-deny --locked --version 0.16.4 || true
72-
- run: cargo deny check bans licenses sources
67+
# EmbarkStudios/cargo-deny-action@v2 runs in a musl container that can't
68+
# install the toolchain pinned by rust-toolchain.toml (issue #103). Also
69+
# fails on smithy (rootless container + NoNewPrivileges). Install +
70+
# invoke cargo-deny directly so the runner's rustup respects the project
71+
# toolchain file. bans/licenses/sources only — advisories live in the
72+
# cargo-audit job above.
73+
- name: Install cargo-deny
74+
run: cargo install --locked cargo-deny --version 0.16.4
75+
- name: Run cargo deny check
76+
run: cargo deny check bans licenses sources
7377

7478
mutants:
7579
name: Mutation Testing

0 commit comments

Comments
 (0)