ci: add criterion benchmark regression gate#122
Merged
Conversation
The verification benchmark code (src/lib/benches/verification_benchmarks.rs) existed with no CI runner, so it caught no regressions. Add a Benchmarks workflow with a PR-triggered fast sanity run (reduced sample size, proves the bench compiles and executes) and a nightly full run that uploads the criterion output as an artifact. Cross-run criterion baseline persistence is intentionally out of scope — it needs an external artifact store sigil doesn't have; the artifact upload is sufficient. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
5 tasks
avrabe
added a commit
that referenced
this pull request
May 20, 2026
Cleanup-cycle release. Minor-versioned (not patch) because the keyless client constructors now return `Result` — a breaking change for code using `wsc` as a library. Contents: - #89 (PR #122): criterion benchmark regression-gate workflow. - #95 (PR #123): Sigstore certificate pinning is now fail-closed — `FulcioClient`/`RekorClient` constructors return `Result`, the unpinned-fallback path is removed, `Default` impls dropped. Internal path-dependency version requirements bumped 0.8.0 → 0.9.0 (the `^0.8.0` ceiling would otherwise reject the 0.9.0 workspace). Deferred and documented: #88 (Kani signature-parser harness — blocked on a BufReader tractability issue) and #46 (SLH-DSA backend — blocked on release-candidate-only ecdsa/p256 crates). #91 closed (MIRAI repo archived). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/benchmarks.yml— the CI gate for the existingcriterion verification benchmarks (
src/lib/benches/verification_benchmarks.rs),which until now had no runner and therefore caught no regressions.
bench-sanity): paths-filtered tosrc/lib/src/**,src/lib/benches/**,Cargo.toml,Cargo.lock— runs a fast sanity check(
cargo bench -p wsc --bench verification_benchmarks -- --sample-size 10 --warm-up-time 1)to prove the bench code compiles and executes without a 10+ minute run.
bench-full):schedule:cron runs the fullcargo benchand uploads
target/criterion/viaactions/upload-artifact@v4.workflow_dispatch:trigger and copies theconcurrency:blockpattern from
formal-verification.yml.Cross-run criterion baseline persistence is intentionally out of scope — it
needs an external artifact store sigil doesn't have; the artifact upload is
sufficient.
Closes #89.
Test plan
cargo build -p wsc --bench verification_benchmarkscompiles cleanly.(
ed25519_verify,dsse_parse_and_verify,merkle_validation,cert_chain_validation) run to Success.bench-sanityjob runs and passes on this PR.bench-fulljob runs and uploads thecriterion-outputartifact.🤖 Generated with Claude Code