feat(rta): Interrupt_Overhead folds into ISR WCET (Tier A #5 cont.)#209
Merged
Conversation
…ont.) Folds Spar_Timing::Interrupt_Overhead into each ISR's effective WCET as 1x per firing — vector dispatch, ISR-context save/restore, EOI ack — mirroring the 2x Context_Switch_Time inflation tasks pay per dispatch (REQ-RTA-008 / PR #198). The ISR pays this kernel-resident interrupt cost once per firing, not twice; default unset = 0 keeps RTA output byte-identical to v0.9.2. Closes the Tier A #5 reviewer follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spar_Timing::Interrupt_Overheadinto each ISR's effective WCET as 1x per firing (vector dispatch, ISR-context save/restore, EOI ack), companion to the 2xContext_Switch_Timetask inflation from PR feat(rta): Context_Switch_Time folded into recurrence (v0.9.2) #198.IsrOverheadInflationInfo diagnostic mirroring the existingOverheadInflationstyle.get_interrupt_overheadaccessor withSpar_Timing-> legacySPAR_Properties-> bare lookup chain for v0.8.x advisory compatibility.Test plan
interrupt_overhead_inflates_isr_wcet— Interrupt_Overhead = 50us inflates 100us ISR -> 150us (1x, not 2x),IsrOverheadInflationdiagnostic emitted.no_interrupt_overhead_byte_identical_to_pre_c1— property absent: no diagnostic, baseline RTA preserved.interrupt_overhead_combined_with_context_switch_for_handler— Sporadic ISR with Interrupt_Overhead AND a handler thread with Context_Switch_Time: ISR side gets 1x, handler thread gets 2x, both diagnostics emitted independently.cargo clippy -p spar-analysis --all-targets -- -D warningsclean;cargo fmt --allclean;rivet validatePASS.Closes the Tier A #5 reviewer follow-up after v0.9.2's task-side context-switch fix (REQ-RTA-010).
🤖 Generated with Claude Code