docs(rivet): VCR-DEC-003 — resolve witness provenance offset-domain (#396)#521
Merged
Merged
Conversation
…396) The one open item on the synth-provenance-v1 contract (#396) is resolved from synth's side, verified from code: synth's op_offsets are ABSOLUTE byte offsets into the original .wasm binary (wasm_decoder.rs feeds the whole module via Parser::new(0).parse_all + reads per-op offsets via into_iter_with_offsets), the same origin as walrus InstrLocId — so the join is direct, no normalization. Replaces the normalization caveat with the real invariant (both tools key off the same input .wasm bytes). Pending only witness's confirmation of the walrus side. Behavior-frozen: docs/traceability only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves the single open item on the
synth-provenance-v1contract (#396, VCR-DEC-003):the offset-normalization domain.
Resolved from synth's side, verified from code (
crates/synth-core/src/wasm_decoder.rs):synth's
op_offsetsare absolute byte offsets into the original.wasmbinary —the decoder feeds the whole module to wasmparser (
Parser::new(0).parse_all(wasm_bytes),base 0) and reads per-op offsets via
into_iter_with_offsets()(whole-buffer positions,not function-body-relative). walrus
InstrLocIdis the same origin, so the witness joinis direct — no per-function header subtraction, no normalization. Pending only witness's
confirmation of the walrus side.
The artifact now carries the real replacement invariant: both tools must key off the same
input
.wasmbytes.Gate
Behavior-frozen — docs/traceability only, no code or
.textchange. rivet validate: 0non-xref errors. Resolution posted on #396 (issuecomment-4813819780).
This unblocks the
synth-provenance-v1emitter (the remaining work is purely synth-internal:tagging each branch op with its
kindthrough both lowering paths).🤖 Generated with Claude Code