Commit 1499ab9
committed
(maint) Use null value with Puppet 7
Previously, in using the unit test workflows with Puppet modules, we set
Puppet 7's PUPPET_FORGE_TOKEN environment variable to '' and in module
Gemfiles evaluated `!ENV['PUPPET_FORGE_TOKEN'].to_s.empty?`.
However, the latest PDK template's (3.5.1) Gemfile evaluates the
PUPPET_FORGE_TOKEN environment variable slightly differently, opting
instead to check whether it exists at all:
https://github.com/puppetlabs/pdk-templates/blob/3.5.1.2/moduleroot/Gemfile.erb#L63
Ruby confusingly evaluates everything besides false and nil as "truthy,"
so an empty string (like the one we set for PUPPET_FORGE_TOKEN) is
evaluated as true.
This commit updates Puppet 7's environment variable to be set to null
instead of an empty string to allow the workflow to be used with PDK
template 3.5.11 parent 5ce8fcd commit 1499ab9
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments