Use explicit hash value syntax instead of shorthand#1285
Merged
Conversation
Replace Ruby 3.1+ shorthand hash syntax (`{ key: }`) with the explicit
form (`{ key: key }`) across spec files and the apt_key provider, and
relax the RuboCop `Style/HashSyntax` rule via `EnforcedShorthandSyntax:
either` so both forms are accepted.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
skyamgarp
reviewed
May 18, 2026
Per review feedback, fully disable `Style/HashSyntax` instead of allowing `EnforcedShorthandSyntax: either`, which could let shorthand creep back in and cause inconsistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
skyamgarp
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ key: }) with the explicit form ({ key: key }) in 4 files (3 spec files + theapt_keyprovider).Style/HashSyntaxviaEnforcedShorthandSyntax: eitherin.rubocop.ymlso both forms are accepted by RuboCop.Files changed
.rubocop.yml— newStyle/HashSyntaxblock withEnforcedShorthandSyntax: either.lib/puppet/provider/apt_key/apt_key.rb—expired:,→expired: expired,.spec/classes/apt_backports_spec.rb— 4×codename:,→codename: codename,.spec/defines/source_spec.rb—id:)→id: id),id:,→id: id,.spec/defines/ppa_spec.rb—environment:,→environment: environment,.Test plan
bundle exec rubocop— 45 files inspected, no offenses detected.pdk validate— exit 0.🤖 Generated with Claude Code