Skip to content

xtrabackup: handle missing facts gracefully#1630

Open
fraenki wants to merge 1 commit into
puppetlabs:mainfrom
markt-de:facts_soft_fail
Open

xtrabackup: handle missing facts gracefully#1630
fraenki wants to merge 1 commit into
puppetlabs:mainfrom
markt-de:facts_soft_fail

Conversation

@fraenki

@fraenki fraenki commented May 8, 2024

Copy link
Copy Markdown
Contributor

Summary

When setting up a new server (or when reinstalling an existing server) with xtrabackup enabled, the Puppet Run may fail:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error:
Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef
(file: /etc/puppetlabs/code/environments/development/modules/mysql/manifests/backup/xtrabackup.pp, line: 53, column: 8) on node

This patch adds a check to verify that the facts are available, before accessing them.

Additional Context

none

Related Issues (if any)

none

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@fraenki fraenki requested review from a team, alexjfisher and bastelfreak as code owners May 8, 2024 13:59
@fraenki fraenki marked this pull request as draft May 8, 2024 14:21
@fraenki fraenki marked this pull request as ready for review August 6, 2024 19:19
@fraenki

fraenki commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants