Skip to content

mysqlbackup: Reenable tests#1642

Open
bastelfreak wants to merge 1 commit into
puppetlabs:mainfrom
bastelfreak:test
Open

mysqlbackup: Reenable tests#1642
bastelfreak wants to merge 1 commit into
puppetlabs:mainfrom
bastelfreak:test

Conversation

@bastelfreak

Copy link
Copy Markdown
Collaborator

Previously the tests were only executed on mysql versions older than 5.7.0. This commit removes the contraint.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@alexjfisher

Copy link
Copy Markdown
Collaborator

There's also this note in the README.

**Note:** The mysqlbackup.sh does not work and is not supported on MySQL 5.7 and greater.

But I don't know how accurate that is. Looks like there have been a number of updates to the script since then.

@bastelfreak bastelfreak force-pushed the test branch 2 times, most recently from 06d9322 to 4cc5ff5 Compare September 20, 2024 15:10
Previously the tests were only executed on mysql versions older than
5.7.0. This commit removes the contraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants