Drop puppet_litmus to resolve patron dependency#805
Merged
Conversation
Commit 6161327 introduced a puppet_litmus dependency which transitively caused bundler to try to install patron 0.13.4. In CI, we don't have libcurl headers installed, so patron failed to install its native extensions. The problem is caused due to this chain of dependencies: puppet_litmus (1.6.1) bolt (~> 4.0) orchestrator_client (~> 0.7) faraday-net_http_persistent (>= 1.0, < 3.0) When resolving dependencies, bundler first picked faraday-net_http_persistent 2.0.2 and worked backwards to faraday. Faraday 1.9.0 allows 2.x versions of faraday-* adapters, while faraday 1.10.4 requires 1.x versions. So bundler backtracked from faraday 1.10.4 to 1.9.0. $ BUNDLER_DEBUG_RESOLVER_TREE=1 bundle install ... attempting faraday-net_http_persistent 2.0.2 knew: faraday-net_http_persistent >= 2.0.0 depends on Ruby >= 2.6.0 fact: faraday-net_http_persistent >= 2.0.2, < 2.1.0 depends on faraday-net_http < 3 fact: faraday-net_http_persistent >= 2.0.0, < 2.2.0 depends on net-http-persistent ~> 4.0 selected faraday-net_http_persistent 2.0.2 ... attempting faraday 1.9.0 ... fact: faraday >= 1.9.0, < 1.9.1 depends on faraday-patron < 3 ... selected faraday 1.9.0 ... attempting faraday-patron 2.0.2 ... selected faraday-patron 2.0.2 derived: patron >= 0.4.2 ... selected patron 0.13.4 Since we don't use litmus to test puppet_agent, just remove the gem dependency.
mhashizume
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6161327 introduced a puppet_litmus dependency which transitively caused bundler to try to install patron 0.13.4. In CI, we don't have libcurl headers installed, so patron failed to install its native extensions.
The problem is caused due to this chain of dependencies:
When resolving dependencies, bundler first picked faraday-net_http_persistent 2.0.2 and worked backwards to faraday. Faraday 1.9.0 allows 2.x versions of faraday-* adapters, while faraday 1.10.4 requires 1.x versions. So bundler backtracked from faraday 1.10.4 to 1.9.0.
Since we don't use litmus to test puppet_agent, just remove the gem dependency.