(maint) Fail if puppetserver can't be started#816
Merged
Conversation
mhashizume
added
the
maintenance
cthorn42
approved these changes
Dec 22, 2025
By default, Beaker tests fail if they give a non-zero exit code. However, when starting puppetserver in the master setup presuite, the resource can fail and still return an exit code of 0. This commit updates the start puppetserver step to use the --fail option, which will return an exit code of 1 if the resource could not be modified.
mhashizume
force-pushed
the
maint/main/puppetserver-fail
branch
from
4f426b7 to
f7e6ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Beaker tests fail if they give a non-zero exit code. However, when starting puppetserver in the master setup presuite, the resource can fail and still return an exit code of 0.
This commit updates the start puppetserver step to use the --fail option, which will return an exit code of 1 if the resource could not be modified.