(PA-8041) Fix puppetcore8-nightly installs on rpm and mac#824
Merged
Conversation
The install task failed to install nightly builds for rpm-based platforms for two different reasons. On SLES, we were running `sed` on a non-existent `/etc/zypp/credentials.d/PuppetcoreCreds`. The SLES nightly release packages don't create that file. Similarly, on other RPM platforms, the nightly release packages don't create `username` or `password` entries in the repo `/etc/yum.repos.d/puppet*release.repo` This adds a guard so we only try to manage credentials for non-nightly core collections. This guard already existed for deb-based platforms.
Installing nightly core builds on mac failed, because it was using the
new scheme. Update the condition to exclude nightly core builds, similar
to what was done for sles and other rpm platforms.
Also when downloading nighlty builds, strip `core` from
the download URL, similar to what we do elsewhere:
repo="/etc/yum.repos.d/${collection/core/}-release.repo"
And release packages
filename="${collection/core/}-release-${deb_codename}.deb"
It's now possible to install nightly core packages without providing PUPPET_FORGE_TOKEN.
…ker container Previously, when running docker/bin/install.sh, you couldn't pass `license-id` as it was hardcoded to `forge-key`.
cthorn42
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightly builds were failing to install on rpm/zypper and mac when using
collection => puppetcore*-nightly, see the first two commits. This wasn't a problem in CI, because it's still using thepuppet8-nightlycollection (here, here, here, here) but overridingyum_sourceIn a future ticket we should remove the non-core nightly collections, as the host was shutdown.
The next two commits fix
docker/bin/install.shwhen testing installs (not using beaker).