(PA-7897) Update to pdk-templates 3.6.1.1#825
Merged
Conversation
joshcooper
force-pushed
the
pdk-template-update-7897
branch
from
2ebd257 to
996dea9
Compare
joshcooper
commented
Apr 23, 2026
Notable pdk template changes: * bumps rubocop to 1.73.x and updates rubocop.yml based on ruby 3.1 target version. * If PUPPET_FORGE_TOKEN env variable is defined, install bolt dependency from puppetcore rubygem source. BOLT_GEM_VERSION can also be used to constrain the gem, like PUPPET_GEM_VERSION. * puppet_litmus 1.6.1 added a minimum bolt 4 requirement. Exclude 1.6.1 until we're ready for bolt 4 in a separate ticket. * drops orchestrator_client pin * disable Style/FileNull as it breaks tests on windows
Previously, rspec tests emitted a "Could not retrieve fact networking.ip". This warning occurs because puppet's compiler adds "server facts" and rspec-puppet replicates this behavior in server_facts_hash[1]. However, none of the test infrastructure provided stubbed values. We used to provide legacy facts for this, like "ipaddress", but they were deleted in commit e22ccfe as part of the move to pdk templates 2.5 This commits adds default_facts.yml back using pdk update --template-ref=3.6.1.1
joshcooper
force-pushed
the
pdk-template-update-7897
branch
from
996dea9 to
75c8f8e
Compare
mhashizume
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #822
bumps rubocop to 1.73.x and updates rubocop.yml based on ruby 3.1 target version.
If PUPPET_FORGE_TOKEN env variable is defined, install bolt dependency from puppetcore rubygem source. BOLT_GEM_VERSION can also be used to constrain the gem, like PUPPET_GEM_VERSION.
puppet_litmus 1.6.1 added a minimum bolt 4 requirement. Exclude 1.6.1 until we're ready for bolt 4 in a separate ticket.
drops orchestrator_client pin
disable Style/FileNull as it breaks tests on windows
Fixes "Could not retrieve fact networking.ip" warning
Also verified puppetcore workflow works: