This repository was archived by the owner on Mar 12, 2024. It is now read-only.
汇率设置#23
Open
EndlessSky512 wants to merge 6 commits into
Open
Conversation
Author
|
已完成修改 |
puppylpg
reviewed
Oct 11, 2020
Owner
puppylpg
left a comment
puppylpg
left a comment
There was a problem hiding this comment.
已完成修改
关于汇率位置的代码再改一下吧，感觉乘的位置不是很合适，后期也不好维护
| self.history_days = days | ||
| self.average_sold_price = self.centered_average(prices) | ||
| self.average_sold_price_after_tax = self.average_sold_price * (1 - STEAM_SELL_TAX) | ||
| self.average_sold_price_after_tax = (self.average_sold_price * (1 - STEAM_SELL_TAX)) * EXCHANGE_RATE |
Owner
There was a problem hiding this comment.
这个货币汇率转化，是不是直接在获取完price后就转换比较好？这样的话从源头价格就已经转换了。在这里转化的话，仅仅average_sold_price_after_tax是新货币，其他价格比如price或者average_sold_price还是原始货币，使用的时候容易出偏差。
|
汇率功能还不能用吗 |
Collaborator
比我想的麻烦 @RaymondMcGuire |
收到 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加了汇率的设置