STREAM-1362: Retry notification subscription#351
Open
AidanWZ wants to merge 6 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
AidanWZ
requested review from
hjon,
maxwellmooney13,
patrickfeeney03 and
zservies
as code owners
bruegg
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry on
ECONNRESET: Switched from requestApi to requestApiWithRetry with maxAttempts: 3 and a 2-second retry interval.Track topic list change: Track the pending retry via pendingBulkSubscribeRetry. When a new makeBulkSubscribeRequest is issued (because the debounce fired again with an updated topic list), the old retry is cancelled. The cancelled bulkSubscribe returns 'Unknown' state for its topics rather than throwing, since the superseding request will carry the correct desired state.
This prevents:
A stale PUT from overwriting the server with an outdated topic list
Unnecessary duplicate requests when the topic list has already changed
Missed subscriptions that were added between retry attempts