[STREAM-1604] - Replace UUID with native alternative#356
Merged
Conversation
UUID is transitive thorugh jest and jest-junit. jest-mock-axios wasnt used
patrickfeeney03
requested review from
hjon,
maxwellmooney13 and
zservies
as code owners
patrickfeeney03
commented
May 22, 2026
|
|
||
| global.window = global; | ||
| global.self = global; | ||
| globalThis.crypto = { randomUUID: jest.fn(() => randomUUID())} |
Collaborator
Author
There was a problem hiding this comment.
Node doesn't have globalThis.crypto... by default so just mock it.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Collaborator
|
We can also remove |
hjon
approved these changes
May 22, 2026
bruegg
approved these changes
May 28, 2026
patrickfeeney03
added a commit
that referenced
this pull request
Jun 5, 2026
* [STREAM-1604] - Replace UUID with native alternative (#356) * Update uuid, first pass UUID is transitive thorugh jest and jest-junit. jest-mock-axios wasnt used * Remove UUID * Add crypto to setup-browser-env * Update tests * Dont bump jest versions yet * Update CHANGELOG * Also bump client logger * remove @types/uuid * lock * Prep v19.8.1 * changelog * fix package version * update changelog * update version to 20 --------- Co-authored-by: Jon Hjelle <jon.hjelle@genesys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build passing in wrapper repo
