[STREAM-1661] Expose current alerting leader status rather than a snapshot of the value#357
Merged
Conversation
…ing a snapshot of the value
hjon
requested review from
maxwellmooney13,
patrickfeeney03 and
zservies
as code owners
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
hjon
commented
May 28, 2026
| off: this.off.bind(this), | ||
| claimAlertingLeader: this.claimAlertingLeader.bind(this), | ||
| getLeaderStatus: () => { return this.leaderStatus; }, | ||
| leaderStatus: this.leaderStatus |
Collaborator
Author
There was a problem hiding this comment.
I have no good explanation for why I thought this would use an up-to-date value. But our clients weren't actually using this before. They need it now.
patrickfeeney03
approved these changes
May 28, 2026
maxwellmooney13
approved these changes
May 28, 2026
peterson-dc
approved these changes
May 28, 2026
bruegg
approved these changes
May 28, 2026
AidanWZ
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.