Gcvcallp 3053#143
Closed
kordian-pawelec wants to merge 6 commits into
Closed
Conversation
kordian-pawelec
requested review from
SubhashC37,
bcnewlin,
benceszigeti,
davidtrihy-genesys and
sekharp-genesys
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Collaborator
|
Just to flag one thing about this PR, most of the changes are related to adding back in the redact_pii |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a mechanism to override redact pattern with 4 modes: replace|append|prepend|format
PII input: sip:user@domain.com
Mode Config Output
replace redact_pii_ = 1 redact_template = "REDACTED" redact_mode = "replace" REDACTED
append redact_pii_ = 1 redact_template = "[PII]" redact_mode = "append" sip:user@domain.com[PII]
prepend redact_pii_ = 1 redact_template = "[PII]" redact_mode = "prepend" [PII]sip:user@domain.com
format redact_pii_ = 1 redact_template = "GenesysPII<%s>" redact_mode = "format" GenesysPIIsip:user@domain.com
Default (no template/mode configured): redact_pii_ = 1 → ****
https://inindca.atlassian.net/browse/GCVCALLP-3053