Support Django 2.0#10
Open
rubengrill wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Some more things to do before creating the new version:
|
|
approved |
|
@rubengrill @topcoderkz Would you mind updating the screenshots & updating the changelog so this branch can be merged? |
|
bump! |
|
Any progress on this? |
jameslao
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @fetux and @jameslao for adding PRs to support Django 2.0.
#9 #5
By just changing the
reverseimport wasn't enough to support 2.0, I got some other errors when running the tests.These fixes + some preparations for the new version are done in this PR.
I dropped support for Django < 1.11 at the same time, to only support versions that are supported by Django itself.
This PR also addresses the issue reported by @Andrew-SK (#1 / #2)
Tests are running now, but the admin is not working in Django 2.0.
The js is not loaded correctly.
@fetux Can you maybe have a look into this?