Open
Conversation
Contributor
|
Have you seen https://github.com/LiamGoodacre/purescript-generics-rep-optics? It also provides optics based on generics-rep. |
Author
|
Ah cool, I was not aware of that library. It seems to need a few slight changes to compile again, and has some differences (like not supporting constructors with zero or more than one argument). While I thought it would be nice to have something dual to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Generic prisms, inspired by Haskell's generic-lens, see
_Ctor._CCin the first example in the test suite can not be inlined (without a type annotation), but_BBcan be inlined without a type signature in the second one. Maybe there are some PureScript-specific tricks (maybe some fundep stuff) to get around this, but I think this PR would be useful even with this slightly suboptimal inferability.Checklist: