Skip to content

feat: reduce HeroBanner size, add tabbed content, update AspireC4#58

Merged
kieronlanning merged 7 commits into
mainfrom
aspirec4-add-image-exampels
May 13, 2026
Merged

feat: reduce HeroBanner size, add tabbed content, update AspireC4#58
kieronlanning merged 7 commits into
mainfrom
aspirec4-add-image-exampels

Conversation

@kieronlanning

Copy link
Copy Markdown
Contributor

Changes

UI Improvements

  • HeroBanner: Reduced vertical padding (py-16 lg:py-24 → py-8 lg:py-12) and font sizes so content is visible above the fold on wide screens

Tabbed Project Content

  • ContentTabs.astro: New component that shows project pages with both local content and a remote GitHub README in tabs rather than stacking them
  • Tab buttons include the GitHub logo icon on the README tab
  • Both tabs have \cursor-pointer\ for correct hover UX
  • Proper ARIA \ ablist/\ abpanel\ semantics, dark mode support

AspireC4 Project

  • Updated content and added makerstack example images

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

kieronlanning and others added 4 commits May 12, 2026 14:51
- Replace Bun with npm throughout (package.json, workflows, instructions)
- Replace husky/hereby with just + lefthook for git hooks and task running
- Update all GitHub Actions to latest major versions (checkout v6, setup-node v6, etc.)
- Fix deprecated z import: use astro/zod instead of astro:content
- Add emoji support to links schema (XOR with image via Zod refine)
- Add markdown linting with markdownlint-cli2 and lefthook integration
- Rebuild site styles: complete dark/light/system theme, mobile-first, accessible
- Add sidebar with ToC and project list on project detail pages
- Limit MainBanner and hero heights on wide screens
- Add AspireC4 project content entry with hasContent + remote README stacking
- Add GitHub README badge to RemoteReadme component
- Fix likec4-wordmark.svg theme responsiveness via colorScheme property
- Lock Vite to <8 as per deprecation warning
- Fix 'Say Hello' contact dialog with captcha support

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ompatibility

@tailwindcss/vite@4.3.0 requires Rolldown (Vite 8 internals) which is
incompatible with astro@6.3.1's Vite 7 dependency. Pinning to the 4.1.x
patch range keeps compatibility until Astro upgrades to Vite 8.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Reduce HeroBanner vertical padding and font sizes so content is
  visible above the fold on wide screens
- Add ContentTabs.astro component: tabbed Overview/GitHub README view
  for project pages that have both local content and a remote README
- GitHub logo icon and cursor-pointer on tab buttons
- Update AspireC4 project content and add makerstack example images
- Tidy MainBanner spacing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 14:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the site’s above-the-fold UX by reducing the Hero banner height, introduces a new tabbed UI to switch between local project content and a remote GitHub README, updates the AspireC4 project write-up with examples/images, and adjusts Tailwind dependency version ranges.

Changes:

  • Reduce HeroBanner padding/font sizes and update the homepage banner content to use the Pill link component.
  • Add ContentTabs.astro and use it on project pages to present “Overview” vs “GitHub README” as tabs when both are available.
  • Expand AspireC4 project content with example screenshots and a code snippet; pin Tailwind packages to patch-only updates (~).

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/src/pages/projects/[...slug].astro Uses the new ContentTabs component when both local content and a remote README exist.
src/src/components/index/MainBanner.astro Updates homepage hero copy and replaces the projects link with a Pill.
src/src/components/HeroBanner.astro Reduces vertical spacing and font sizes to make content more visible above the fold.
src/src/components/ContentTabs.astro New tab UI component with ARIA roles and client-side behavior to switch panels.
src/src/collections/projects/AspireC4.md Updates AspireC4 description and adds examples/images and a code snippet.
src/package.json Changes Tailwind dependency ranges from ^ to ~ (patch-only updates).
src/package-lock.json Reflects the resulting dependency resolution changes from the Tailwind range adjustment.
Files not reviewed (1)
  • src/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

src/src/collections/projects/AspireC4.md:74

  • There’s a likely typo in the example summary text: “MarkerStack SPA” vs “MakerStack SPA”. If the project name is MakerStack elsewhere in the doc, this should be made consistent.
        .WithLabel("Web Host")
        .WithSummary(".NET 10/ ASP.NET Minimal API web app. Hosting APIs, and the Astro-based landing site and the MarkerStack SPA");
    })

src/src/collections/projects/AspireC4.md:76

  • Inside a csharp code fence, # Note ... isn’t valid C# (should be //), and the line ending .. reads like a typo. Adjusting this keeps the example consistent and copy/pasteable.
        .WithSummary(".NET 10/ ASP.NET Minimal API web app. Hosting APIs, and the Astro-based landing site and the MarkerStack SPA");
    })
    # Note the reference to the database project here, to save you from calling .WithReference(db) as well..
    .WithLikeC4Reference(db, opts => {

Comment thread src/src/collections/projects/AspireC4.md Outdated
Comment thread src/src/components/ContentTabs.astro
Comment thread src/src/collections/projects/AspireC4.md
Comment on lines 8 to 12
<HeroBanner
backgroundImgSrc={backgroundImg}
title='Digital Delivery Consultancy'
subtitle='Accelerating your projects and teams.'
title="Digital Delivery Consultancy"
subtitle="Accelerating your projects and teams."
>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 66975f2src/src/components/index/MainBanner.astro now uses single-quoted Astro/HTML attributes to match the existing repo style. No UI behavior or visual output changed in this update.

Comment thread src/package.json
Comment thread src/package.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kjldev/kjldev/sessions/bbda4125-85f2-49f0-a870-b3b6dbc5db04

Co-authored-by: kieronlanning <5364423+kieronlanning@users.noreply.github.com>

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/kjldev/kjldev/src/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@kieronlanning
kieronlanning enabled auto-merge (squash) May 13, 2026 16:11
@kieronlanning
kieronlanning merged commit 122919e into main May 13, 2026
1 check passed
@kieronlanning
kieronlanning deleted the aspirec4-add-image-exampels branch May 13, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants