Commit 7166229
authored
Skip cloner perf test and fix ray caster intrinsics camera pose (isaac-sim#5470)
# Description
Two unrelated CI flakes in the same test infrastructure area, bundled
because both are minimal targeted fixes.
### 1. `test_disabled_fabric_change_notifies_speedup_regression`
(`source/isaaclab_physx/test/sim/test_cloner.py`)
This is a wall-clock perf regression test that's intended to run
**locally only** — it asserts a >= 1.2× speedup of clone+reset with
listener suspension. The result is platform-sensitive (deferred Fabric
resync in `sim.reset` can offset the scene-time savings on some
hardware), so it was meant to be skipped in CI.
The original guard was `if os.getenv(\"CI\", \"\").lower() in (\"true\",
\"1\"): pytest.skip(...)` inside the test body. However, this project's
CI doesn't set the `CI` env var — it selects tests via the `isaacsim_ci`
pytest marker registered in `pyproject.toml` and applied module-wide via
`pytestmark` at the top of `test_cloner.py`. Result: the env-var skip
never fires, and the test runs (and occasionally flakes) on CI.
Fix: replace the dead env-var branch with a top-level
`@pytest.mark.skip(...)` decorator so the test is collected and skipped
unconditionally regardless of how CI selects tests. The correctness of
the suspension mechanism is still covered by
`test_disabled_fabric_change_notifies_toggles_ifabricusd_flag`, which is
unaffected. Re-enable the perf test manually when touching listener
suspension.
### 2. `test_output_equal_to_usd_camera_when_intrinsics_set`
(`source/isaaclab/test/sensors/test_ray_caster_camera.py`)
Intermittent CI failure where the ray caster camera output mismatched
the USD camera reference with inf-valued differences across all 518400
elements:
```
E Mismatched elements: 518400 / 518400 (100.0%)
E Greatest absolute difference: inf at index (0, 0, 0, 0) (up to 0.0001 allowed)
E Greatest relative difference: inf at index (0, 0, 0, 0) (up to 0.005 allowed)
```
Root cause: the test placed the camera at `eye=(0, 0, 5)` looking at
`target=(0, 0, 0)`, which is colinear with the default up vector and
produces a degenerate view transform. Fix: nudge `eye` to `(0.001, 0,
5)` for both the ray caster and USD camera, keeping them at identical
poses while breaking the singularity. The underlying degeneracy is
tracked in a separate internal ticket; this is the test-side mitigation.
Fixes # (n/a)
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Screenshots
N/A — test infrastructure changes.
## Checklist
- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there1 parent 8bb6eff commit 7166229
2 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
898 | 898 | | |
899 | 899 | | |
900 | 900 | | |
901 | | - | |
| 901 | + | |
902 | 902 | | |
903 | 903 | | |
904 | 904 | | |
905 | | - | |
| 905 | + | |
906 | 906 | | |
907 | 907 | | |
908 | 908 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
552 | 552 | | |
553 | 553 | | |
554 | 554 | | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
555 | 562 | | |
556 | 563 | | |
557 | 564 | | |
558 | | - | |
| 565 | + | |
559 | 566 | | |
560 | 567 | | |
561 | 568 | | |
| |||
564 | 571 | | |
565 | 572 | | |
566 | 573 | | |
567 | | - | |
568 | 574 | | |
569 | 575 | | |
570 | 576 | | |
| |||
573 | 579 | | |
574 | 580 | | |
575 | 581 | | |
576 | | - | |
577 | | - | |
578 | 582 | | |
579 | 583 | | |
580 | 584 | | |
| |||
0 commit comments