Skip to content

Commit a0e07b4

Browse files
Forbid pushing to origin in AGENTS.md (isaac-sim#5344)
# Description The origin remote points to the public isaac-sim/IsaacLab repo. Agents and contributors should push to their own fork remote or to the remote of the PR they are working on instead. ## Type of change - Documentation update ## Checklist - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent 0c565d6 commit a0e07b4

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

AGENTS.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ We use a wrapped python call within `./isaaclab.sh`.
6464

6565
### Pre-commit (lint/format hooks)
6666

67-
**CRITICAL: Always run pre-commit hooks BEFORE committing, not after.**
67+
**CRITICAL: Always run pre-commit hooks BEFORE committing and BEFORE pushing.**
6868

6969
Proper workflow:
7070
1. Make your code changes
@@ -73,15 +73,17 @@ Proper workflow:
7373
4. Stage the modified files with `git add`
7474
5. Run `./isaaclab.sh -f` again to ensure all checks pass
7575
6. Only then create your commit with `git commit`
76+
7. Verify pre-commit still passes before pushing — never push commits that haven't been checked
7677

7778
```bash
7879
# Run pre-commit checks on all files
7980
./isaaclab.sh -f
8081
```
8182

82-
**Common mistake to avoid:**
83+
**Common mistakes to avoid:**
8384
- Don't commit first and then run pre-commit (requires amending commits)
84-
- Do run pre-commit before committing (clean workflow)
85+
- Don't push before running pre-commit (pushes broken code to the remote)
86+
- Do run pre-commit before committing and before pushing (clean workflow)
8587

8688
**When reviewing code** (e.g. via a code-reviewer agent), always run `./isaaclab.sh -f` as part of the review to catch formatting or lint issues early.
8789

@@ -152,6 +154,7 @@ Follow conventional commit message practices.
152154
## Sandbox & Networking
153155

154156
- Network access (e.g., `git push`) is blocked by the sandbox. Use `dangerouslyDisableSandbox: true` so the user gets an approval prompt — don't ask them to run it manually.
157+
- **Never push to `origin` (`isaac-sim/IsaacLab`).** The `origin` remote is the public upstream repository. Push to your own fork remote (e.g., `antoine`, `alex`) or to the remote of the PR you are working on. If the correct remote is unclear, ask the user before pushing.
155158

156159
## GitHub Actions and CI/CD
157160

0 commit comments

Comments
 (0)