Skip to content

Commit fce831e

Browse files
committed
Implement suggested changes from review
1 parent 97f1ee4 commit fce831e

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

pvlib/iotools/era5.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,10 @@ def get_era5(latitude, longitude, start, end, variables, api_key,
6666
6767
A CDS API key is needed to access this API. Register for one at [1]_.
6868
69-
This API [2]_ provides a subset of the full ERA5 dataset. See [3]_ for
70-
the available variables. Data are available on a 0.25° x 0.25° grid.
71-
69+
This API [2]_ provides a subset of parameters of the full ERA5 datasets,
70+
see [3]_ for available variables. A comparison of ERA5 and ERA5-land is
71+
available in [4]_.
72+
7273
Parameters
7374
----------
7475
latitude : float
@@ -116,6 +117,7 @@ def get_era5(latitude, longitude, start, end, variables, api_key,
116117
.. [1] https://cds.climate.copernicus.eu/
117118
.. [2] https://cds.climate.copernicus.eu/datasets/reanalysis-era5-single-levels-timeseries?tab=overview
118119
.. [3] https://confluence.ecmwf.int/pages/viewpage.action?pageId=505390919
120+
.. [4] https://confluence.ecmwf.int/display/CKB/The+family+of+ERA5+datasets
119121
""" # noqa: E501
120122

121123
def _to_utc_dt_notz(dt):

tests/iotools/test_era5.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ def test_get_era5(params, expected):
5555
def test_get_era5_land(params, expected):
5656
params['dataset'] = "reanalysis-era5-land-timeseries"
5757
df, meta = pvlib.iotools.get_era5(**params)
58-
assert meta['longitude'] == -80.0
59-
assert meta['latitude'] == 40.0
58+
assert np.isclose(meta['longitude'], -80.0)
59+
assert np.isclose(meta['latitude'], 40.0)
6060
assert pd.testing.assert_index_equal(df.index, expected.index)
6161

6262

0 commit comments

Comments
 (0)