Show distribution file sizes in publish.yml GH Actions workflow#2278
Merged
Conversation
Member
Author
|
The publish job now shows filesizes for the distribution files: and installed files: |
echedey-ls
approved these changes
Oct 23, 2024
echedey-ls
left a comment
echedey-ls
left a comment
Member
There was a problem hiding this comment.
Nice idea and nice PR. Minor suggestions down below, feel free to discard them. I would prefer to have all the sizes in the same step so it gets expanded in a click, but it's fine as is.
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Member
Author
|
Seems like there are no objections here, so I will go ahead and merge. Thanks for the review @echedey-ls! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.With ongoing work around reducing the size of our distribution files, it is helpful to log the filesize in PR dist builds.