changed default types to float in solarposition.py

[kurt-rhee]

• Closes (NONE)
• I am familiar with the contributing guidelines
• Tests added
• Updates entries in docs/sphinx/source/reference for API changes.
• Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
• New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
• Pull request is nearly complete and ready for detailed review.
• Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I have added type hints to get_solarposition() and I have also changed the default values of the function inputs to float instead of int to make my linter stop yelling at me.

[kurt-rhee]

This pull request will fail on flake8 due to line lengths on some of the documentation. I am not sure how to fix it.

[cwhanse]

I have added type hints to get_solarposition()

There have been debates on adding type hints, and I don't think we're agreed that pvlib benefits by adding them.

Specifying float for those defaults is not controversial; thanks for doing that.

[kurt-rhee]

Got it, happy to remove type hinting if that helps push this PR through.

[kandersolar]

Agreed, there is no consensus about adopting type hints in pvlib. Until then, no hints!

Nitpick: if the default values are changing from int to float (e.g. 12 to 12.0), then the docstrings should change as well (temperature : float, default 12. instead of temperature : float, default 12).

[kurt-rhee]

@kandersolar good point! I'll give that a quick edit today

[kandersolar]

LGTM after the linter complaint is resolved

[kandersolar]

Reverting a couple linter-related changes, as they seem to render poorly in the sphinx output and are not required for this PR

[kandersolar]

Thanks @kurt-rhee!