Skip to content

Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia#2317

Merged
kandersolar merged 5 commits into
pvlib:mainfrom
RDaxini:sdm_returns
Dec 3, 2024
Merged

Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia#2317
kandersolar merged 5 commits into
pvlib:mainfrom
RDaxini:sdm_returns

Conversation

@RDaxini

@RDaxini RDaxini commented Dec 3, 2024

Copy link
Copy Markdown
Member
  • Closes Parameters missing from ivtools.sdm.fit_desoto_sandia returns statement #2315
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini added this to the v0.11.2 milestone Dec 3, 2024
@RDaxini RDaxini marked this pull request as ready for review December 3, 2024 17:21
@RDaxini RDaxini marked this pull request as draft December 3, 2024 17:22
Comment thread pvlib/ivtools/sdm.py Outdated
@RDaxini RDaxini marked this pull request as ready for review December 3, 2024 17:27
@RDaxini RDaxini changed the title [WIP] Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia Dec 3, 2024
Comment thread pvlib/ivtools/sdm.py Outdated
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Comment thread pvlib/ivtools/sdm.py Outdated
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini

@kandersolar kandersolar merged commit a17da47 into pvlib:main Dec 3, 2024
@RDaxini RDaxini deleted the sdm_returns branch December 3, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameters missing from ivtools.sdm.fit_desoto_sandia returns statement

3 participants