Remove psm3.py#2582
Merged
Merged
Conversation
kandersolar
added
remote-data
AdamRJensen
added
remote-data
AdamRJensen
approved these changes
Oct 28, 2025
AdamRJensen
left a comment
AdamRJensen
left a comment
Member
There was a problem hiding this comment.
Docs have no warnings and tests are passing, LGTM
9 tasks
karlhillx
added a commit
to karlhillx/pvlib-python
that referenced
this pull request
Jun 22, 2026
Fixes pvlib#2791. The oedi_9068 gallery example calls get_nsrdb_psm4_conus() with interval=5, but the function's parameter is named time_step (the interval name comes from the NSRDB API query string, not the Python signature). This was missed when PR pvlib#2582 migrated the example from get_psm3 (which used interval) to get_nsrdb_psm4_conus (which uses time_step). Changes interval=5 to time_step=5 in the example call. No test changes needed — test_get_nsrdb_psm4_conus_5min already exercises time_step=5 against the function directly.
kandersolar
added a commit
that referenced
this pull request
Jul 4, 2026
* Fix interval keyword argument in oedi_9068 gallery example Fixes #2791. The oedi_9068 gallery example calls get_nsrdb_psm4_conus() with interval=5, but the function's parameter is named time_step (the interval name comes from the NSRDB API query string, not the Python signature). This was missed when PR #2582 migrated the example from get_psm3 (which used interval) to get_nsrdb_psm4_conus (which uses time_step). Changes interval=5 to time_step=5 in the example call. No test changes needed — test_get_nsrdb_psm4_conus_5min already exercises time_step=5 against the function directly. * Apply review feedback: update PSM3→PSM4 references and add contributor - Update narrative comments from 'NSRDB PSM3' to 'NSRDB PSM4' to match the actual function called (get_nsrdb_psm4_conus) - Rename psm3/psm3_metadata variables to psm4/psm4_metadata for consistency with the PSM4 data source - Add Karl Hill to Contributors in v0.15.3 whatsnew Addresses Copilot suggestions (+1 from @cwhanse) on PR #2793. --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_psm3no longer works #2581docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.As described in #2581.