Skip to content

Add tzdata to fix ReadTheDocs build and vendor timezone data #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwhanse merged 2 commits into from
Jul 7, 2026
+3 −0
Merged

Add tzdata to fix ReadTheDocs build and vendor timezone data #2809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c6557
add tzdata to fix readthedocs build
yonryzhu Jul 6, 2026
e61e40c
fix whatsnew and add clarifying tzdata comment
yonryzhu Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew/v0.15.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Deprecations

Bug fixes
~~~~~~~~~
* Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`)

@echedey-ls echedey-ls Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`)
* Fix missing timezones by adding ``tzdata`` as a dependency. (:issue:`2795`, :pull:`2809`)

I don't consider this to be a user-facing bugfix, so I rather have one entry in enhancements (like "ensure all timezones are available in all OSes") and another one in maintenance (e.g. "fix documentation builds on runner images lacking link-type timezones"



Enhancements
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dependencies = [
'requests',
'scipy >= 1.7.2',
'h5py',
'tzdata',

@echedey-ls echedey-ls Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'tzdata',
'tzdata', # ensure all timezones are available in all installs for consistency GH#2795

]
license = "BSD-3-Clause"
classifiers = [
Expand Down
Loading