Fix broken anchor links#1877
Conversation
…n.md, TextColumns.md and TextRegion.md.
|
I also found some links that lead to the documentation instead of the API reference. For example: https://py-pdf.github.io/fpdf2/Links.html#hyperlink-with-write_html Just wanted to ask if this is intentional. |
Doesn't look intentional to me - linking to the API reference would make more sense. Do you want to add this change? Also, can you add a quick CHANGELOG.md entry saying you fixed several links on the docs? I'm good to merge after that. |
Yes, I can add this change I'll also add a CHANGELOG.md entry stating the changes. |
Yes. One line is more than enough |
|
@andersonhc, I have completed the changes. Should I do anything else? |
|
@allcontributors please add @iamfazakb for docs |
|
I've put up a pull request to add @iamfazakb! 🎉 |
No worries about mentioning people :) The PR has been merged. Thank you for your contribution. |
Just changed some anchor links to directly take you to their API documentation instead of just leaving you at the top of the page. The pages and their sections were:
https://py-pdf.github.io/fpdf2/TextRegion.html#general-operation
https://py-pdf.github.io/fpdf2/Margins.html#margins
https://py-pdf.github.io/fpdf2/PageFormatAndOrientation.html#page-layout-zoom-level
https://py-pdf.github.io/fpdf2/TextColumns.html#text-columns
https://py-pdf.github.io/fpdf2/Images.html#output-intents
Fixes #1876
Is writing changes to the documentations in
CHANGELOG.mdnecessary?A mention of the change is present in
CHANGELOG.mdThis PR is ready to be merged
This is my first time contributing and I was really nervous. That's why I decided to start small to get used to it. I would really appreciate advice and criticism.
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.