MAINT: minor code improvements (#129)

Author: Lucas-C

pdfly/booklet.py

@@ -17,8 +17,6 @@
 # All rights reserved. This software is available under a BSD license;
 # see https://github.com/py-pdf/pypdf/LICENSE
 
-import sys
-import traceback
 from pathlib import Path
 from typing import Generator, Optional, Tuple
 
@@ -89,10 +87,8 @@ def main(
         with open(output, "wb") as output_fh:
             writer.write(output_fh)
 
-    except Exception:
-        print(traceback.format_exc(), file=sys.stderr)
-        print(f"Error while reading {filename}", file=sys.stderr)
-        sys.exit(1)
+    except Exception as error:
+        raise RuntimeError(f"Error while processing {filename}") from error
 
 
 def requires_rotate(a: RectangleObject, b: RectangleObject) -> bool:

pdfly/cat.py

@@ -44,12 +44,10 @@
 
 import os
 import sys
-import traceback
 from pathlib import Path
 from typing import List, Optional, Tuple
 
 from pypdf import PageRange, PdfReader, PdfWriter, parse_filename_page_ranges
-from pypdf.errors import FileNotDecryptedError
 
 
 def main(
@@ -104,14 +102,8 @@ def main(
                 for page_num in range(*page_range.indices(len(reader.pages))):
                     writer.add_page(reader.pages[page_num])
         writer.write(output_fh)
-    except FileNotDecryptedError as error:
-        print(str(error), file=sys.stderr)
-        print(f"Error while reading {filename}", file=sys.stderr)
-        sys.exit(1)
-    except Exception:
-        print(traceback.format_exc(), file=sys.stderr)
-        print(f"Error while reading {filename}", file=sys.stderr)
-        sys.exit(1)
+    except Exception as error:
+        raise RuntimeError(f"Error while reading {filename}") from error
     finally:
         output_fh.close()
     # In 3.0, input files must stay open until output is written.