ENH: check-sign command prints a single line result

Author: moormaster

pdfly/check_sign.py

@@ -24,23 +24,25 @@ def main(filename: Path, pem: Path, verbose: Optional[bool]) -> None:
     if len(results) == 0:
         raise typer.BadParameter("Signature missing")
 
+    details: list[str] = []
     for hash_ok, signature_ok, cert_ok in results:
         if not signature_ok:
-            print(f"Signature ok: {signature_ok}", file=sys.stderr)
+            details.append("Signature not ok")
         elif verbose:
-            print(f"Signature ok: {signature_ok}")
+            details.append("Signature ok")
         if not hash_ok:
-            print(f"Content hash ok: {hash_ok}", file=sys.stderr)
+            details.append("Content hash not ok")
         elif verbose:
-            print(f"Content hash ok: {hash_ok}")
+            details.append("Content hash ok")
         if not cert_ok:
-            print(f"Certificate ok: {cert_ok}", file=sys.stderr)
+            details.append("Certificate not ok")
         elif verbose:
-            print(f"Certificate ok: {cert_ok}")
+            details.append("Certificate ok")
 
+    details_str = "" if len(details) == 0 else " (" + ", ".join(details) + ")"
     for hash_ok, signature_ok, cert_ok in results:
         if not signature_ok or not hash_ok or not cert_ok:
-            print("Failure", file=sys.stderr)
+            print(f"Check failed{details_str}.", file=sys.stderr)
             raise typer.Exit(code=1)
 
-    print("Success")
+    print(f"Check succeeded{details_str}.")

tests/test_check_sign.py

@@ -36,7 +36,8 @@ def test_check_sign_manipulated_content(capsys, tmp_path):
 
     # Assert
     assert exit_code == 1
-    assert "Content hash ok: False" in captured.err
+    assert "Check failed" in captured.err
+    assert "Content hash not ok" in captured.err
 
 
 def test_check_sign_missing_signature(capsys, tmp_path):
@@ -74,7 +75,8 @@ def test_check_sign_signature_not_matching_to_certificate(capsys, tmp_path):
 
     # Assert
     assert exit_code == 1
-    assert "Certificate ok: False" in captured.err
+    assert "Check failed" in captured.err
+    assert "Certificate not ok" in captured.err
 
 
 def test_check_sign_pem(capsys, tmp_path):