ENH: Add a rotate command, per discussion#128
Merged
Conversation
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Lucas-C
reviewed
May 26, 2025
Member
|
The Also could you add a mention of this nice addition into |
Member
|
@all-contributors please add @hwine for code: 17ba644 |
rotate command, per discussionrotate command, per discussion
Contributor
Author
|
@Lucas-C thanks for catching my "oops" -- I believe I've addressed all of your comments |
Lucas-C
reviewed
May 26, 2025
`uv` claims requirements don't work for python 3.7, and 3.7 is listed as not being tested.
May be removed in PR, but I want to ensure no changes while I do the work.
`direnv` is a common developer tool, but not part of this projects standard development process.
Test coverage now all but execption handling in pdfly/rotate.py
Will not be part of final commit, but shows no regressions in failed tests due to changes
Co-authored-by: Lucas Cimon <925560+Lucas-C@users.noreply.github.com>
Co-authored-by: Lucas Cimon <925560+Lucas-C@users.noreply.github.com>
Not caught in local `pre-commit` run Co-authored-by: Lucas Cimon <925560+Lucas-C@users.noreply.github.com>
Lucas-C
approved these changes
May 27, 2025
Member
|
This new command has been included in the latest 0.5.0 release: https://github.com/py-pdf/pdfly/releases/tag/0.5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
rotatesub command to rotate the specified pages by the specified degrees. Design as discussed in #119 (exceptions noted at end).Current status:
pdfly rotate --helpThe not-implemented-as-discussed elements are: