Fix RLCD stage-one setup and dependency handling#268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stage1_ges_sparsityto GES through the effectivelambda_valueargumentcommunitiesdependency with NetworkX for maximal-clique enumerationBackground
The NumPy 2 scalar-conversion failure in the released 0.1.4.7 package is real, but it was already fixed on
mainby #263. The remaining RLCD stage-1 issues were still present on currentmain: an alternate backend referenced files absent from causal-learn,stage1_ges_sparsitywas silently ignored by GES, and importing RLCD required an optional package that a base installation did not provide.The GES sparsity default changes from
2to0.5to preserve the value that GES previously used after ignoring the obsoletelambdakey.Testing
pytest -q tests/TestRLCD.py: 5 passed with NumPy 1.26.4pytest -q tests/TestRLCD.py: 5 passed with NumPy 2.4.4communitiesinstallationgit diff --checkpassedThe existing GES accuracy assertion also fails on untouched
main; this change does not modify GES scoring code.