Skip to content

Commit 4887eb0

Browse files
Fix schema-qualified table name assertions in reflection tests
When MetaData is initialized with a schema parameter, SQLAlchemy uses schema-qualified table names (e.g., "schema.table_name") as keys in meta.tables dictionary. Update test_get_table_names and test_get_view_names to use proper schema-qualified names when checking for table presence in reflected metadata. Fixes CI test failures caused by schema specification changes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 7793651 commit 4887eb0

1 file changed

Lines changed: 14 additions & 6 deletions

File tree

tests/pyathena/sqlalchemy/test_base.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,13 @@ def test_get_table_names(self, engine):
159159
engine, conn = engine
160160
meta = MetaData(schema=ENV.schema)
161161
meta.reflect(bind=engine)
162-
assert "one_row" in meta.tables
163-
assert "one_row_complex" in meta.tables
164-
assert "view_one_row" not in meta.tables
162+
# With schema specified, table names are schema-qualified
163+
schema_qualified_one_row = f"{ENV.schema}.one_row"
164+
schema_qualified_one_row_complex = f"{ENV.schema}.one_row_complex"
165+
schema_qualified_view_one_row = f"{ENV.schema}.view_one_row"
166+
assert schema_qualified_one_row in meta.tables
167+
assert schema_qualified_one_row_complex in meta.tables
168+
assert schema_qualified_view_one_row not in meta.tables
165169

166170
insp = sqlalchemy.inspect(engine)
167171
assert "many_rows" in insp.get_table_names(schema=ENV.schema)
@@ -170,9 +174,13 @@ def test_get_view_names(self, engine):
170174
engine, conn = engine
171175
meta = MetaData(schema=ENV.schema)
172176
meta.reflect(bind=engine, views=True)
173-
assert "one_row" in meta.tables
174-
assert "one_row_complex" in meta.tables
175-
assert "view_one_row" in meta.tables
177+
# With schema specified, table names are schema-qualified
178+
schema_qualified_one_row = f"{ENV.schema}.one_row"
179+
schema_qualified_one_row_complex = f"{ENV.schema}.one_row_complex"
180+
schema_qualified_view_one_row = f"{ENV.schema}.view_one_row"
181+
assert schema_qualified_one_row in meta.tables
182+
assert schema_qualified_one_row_complex in meta.tables
183+
assert schema_qualified_view_one_row in meta.tables
176184

177185
insp = sqlalchemy.inspect(engine)
178186
actual = insp.get_view_names(schema=ENV.schema)

0 commit comments

Comments
 (0)