Skip to content

Commit e9b147c

Browse files
Remove redundant S3Metadata.__eq__
collections.abc.Mapping already provides __eq__ that compares against any Mapping (dict is a registered subclass), which covers both S3Metadata-to-S3Metadata and S3Metadata-to-dict comparison over the user-defined metadata. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 03b08d1 commit e9b147c

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

pyathena/filesystem/s3_object.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -236,13 +236,6 @@ def __iter__(self) -> Iterator[str]:
236236
def __len__(self) -> int:
237237
return len(self._user_metadata)
238238

239-
def __eq__(self, other: object) -> bool:
240-
if isinstance(other, S3Metadata):
241-
return self._user_metadata == other._user_metadata
242-
if isinstance(other, Mapping):
243-
return self._user_metadata == dict(other)
244-
return NotImplemented
245-
246239
def __repr__(self) -> str:
247240
return f"{self.__class__.__name__}({self._user_metadata!r})"
248241

0 commit comments

Comments
 (0)