Fix MetaData schema specification in SQLAlchemy tests#593
Merged
Conversation
Add schema=ENV.schema parameter to MetaData() instances that were missing explicit schema specification. This ensures proper test isolation and consistency across test environments. Changes: - test_reflect_table: Add schema to MetaData for one_row table - test_reflect_table_include_columns: Add schema to MetaData for one_row_complex table - test_partition_table_columns: Add schema to MetaData for partition_table - test_get_table_names: Add schema to MetaData for table reflection - test_get_view_names: Add schema to MetaData for view reflection - test_create_table: Add schema to MetaData for table creation All TODO comments regarding schema specification have been resolved. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
When MetaData is initialized with a schema parameter, SQLAlchemy uses schema-qualified table names (e.g., "schema.table_name") as keys in meta.tables dictionary. Update test_get_table_names and test_get_view_names to use proper schema-qualified names when checking for table presence in reflected metadata. Fixes CI test failures caused by schema specification changes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema=ENV.schemaparameter to 6 test methodsChanges
Test plan
This PR addresses TODO comments that were added to identify missing schema specifications in test metadata.
🤖 Generated with Claude Code