Remove --sort-by definition

Remove the CLI option, we cannot robustly support it with class-body
dependencies.

Author: ax3l

README.md

@@ -35,7 +35,6 @@ pybind11-stubgen [-h]
                  [--print-invalid-expressions-as-is]
                  [--print-safe-value-reprs REGEX]
                  [--exit-code]
-                 [--sort-by {definition,topological}]
                  [--stub-extension EXT]
                  MODULE_NAME [MODULE_NAMES ...]
 ```

pybind11_stubgen/__init__.py

@@ -77,7 +77,6 @@ class CLIArgs(Namespace):
     exit_code: bool
     dry_run: bool
     stub_extension: str
-    sort_by: str
     module_names: list[str]
 
 
@@ -217,16 +216,6 @@ def regex_colon_path(regex_path: str) -> tuple[re.Pattern, str]:
         "Must be 'pyi' (default) or 'py'",
     )
 
-    parser.add_argument(
-        "--sort-by",
-        type=str,
-        default="definition",
-        choices=["definition", "topological"],
-        help="Order of classes in generated stubs. "
-        "'definition' (default) preserves the order from the module. "
-        "'topological' sorts by inheritance hierarchy.",
-    )
-
     parser.add_argument(
         "module_names",
         metavar="MODULE_NAMES",
@@ -321,10 +310,7 @@ def main(argv: Sequence[str] | None = None) -> None:
     args = arg_parser().parse_args(argv, namespace=CLIArgs())
 
     parser = stub_parser_from_args(args)
-    printer = Printer(
-        invalid_expr_as_ellipses=not args.print_invalid_expressions_as_is,
-        sort_by=args.sort_by,
-    )
+    printer = Printer(invalid_expr_as_ellipses=not args.print_invalid_expressions_as_is)
 
     run(
         parser,

pybind11_stubgen/printer.py

@@ -136,9 +136,8 @@ def _add_edge(dependency: str, dependent: str) -> None:
 
 
 class Printer:
-    def __init__(self, invalid_expr_as_ellipses: bool, sort_by: Literal["definition", "topological"] = "definition"):
+    def __init__(self, invalid_expr_as_ellipses: bool):
         self.invalid_expr_as_ellipses = invalid_expr_as_ellipses
-        self.sort_by = sort_by
 
     def _order_classes(self, classes: list[Class]) -> list[Class]:
         return _topological_sort_classes(classes)