Add optional concrete fallback definition after overload stubs#313
Closed
dyollb wants to merge 2 commits into
Closed
Add optional concrete fallback definition after overload stubs#313dyollb wants to merge 2 commits into
dyollb wants to merge 2 commits into
Conversation
Contributor
Author
|
maybe this is a bug/issue in griffe and does not need a solution in pybind stubgen |
Contributor
|
This does not seem to be required for using stubs for typechecking purposes. I don't seem to have an issue when running .pyi through e.g. mypy, even though more recent typechekers like zuban, ty and pyrefly need separate testing. |
Contributor
Author
|
I agree. It is even marked as bug in griffe. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional concrete fallback definition after overload stubs
Why:
Some tools (for example Griffe during re-export resolution) cannot reliably resolve symbols defined only as overload stubs. Emitting a concrete non-overload signature after the overload set preserves typing quality while ensuring symbol resolution works.
What: