Skip to content

Commit 5a6edc9

Browse files
franzpoeschelrwgk
andauthored
Exclude MSVC up to 19.16 from using std::launder (#5968)
* Exclude further MSVC versions from std::launder Versions 19.4, 19.5 and 19.6 now also excluded. Error seen with 19.6, error triggered by this commit: 57b9a0a _deps\fetchedpybind11-src\include\pybind11\pybind11.h(3008): fatal error C1001: An internal error has occurred in the compiler. [C:\projects\openpmd-api\build\openPMD.py.vcxproj] (compiler file 'd:\agent\_work\8\s\src\vctools\compiler\utc\src\p2\main.c', line 187) To work around this problem, try simplifying or changing the program near the locations listed above. Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information * Add minimal comment // See PR #5968 --------- Co-authored-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
1 parent 53ccc32 commit 5a6edc9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/pybind11/detail/common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
# endif
8888
#endif
8989

90-
#if defined(__cpp_lib_launder) && !(defined(_MSC_VER) && (_MSC_VER < 1914))
90+
#if defined(__cpp_lib_launder) && !(defined(_MSC_VER) && (_MSC_VER < 1920)) // See PR #5968
9191
# define PYBIND11_STD_LAUNDER std::launder
9292
# define PYBIND11_HAS_STD_LAUNDER 1
9393
#else

0 commit comments

Comments
 (0)