Fix clang-tidy warning, compare pointer to nullptr

b-pass · b-pass · commit 8bcab79a49f9 · 2025-05-09T19:34:34.000-04:00
diff --git a/tests/test_embed/test_interpreter.cpp b/tests/test_embed/test_interpreter.cpp
@@ -262,7 +262,7 @@ bool has_state_dict_internals_obj() {
 
 bool has_pybind11_internals_static() {
     auto *&ipp = py::detail::get_internals_pp();
-    return ipp && (*ipp != nullptr);
+    return (ipp != nullptr) && *ipp;
 }
 
 TEST_CASE("Restart the interpreter") {

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ bool has_state_dict_internals_obj() {`
`262`	`262`
`263`	`263`	`bool has_pybind11_internals_static() {`
`264`	`264`	`auto *&ipp = py::detail::get_internals_pp();`
`265`		`- return ipp && (*ipp != nullptr);`
	`265`	`+ return (ipp != nullptr) && *ipp;`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`TEST_CASE("Restart the interpreter") {`