chore: update nox and test deps#5594
Merged
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/nox2025
branch
from
78e65d1 to
807c707
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates testing dependencies and modernizes script runners, notably updating the shebangs for Python scripts and refining nox session usage.
- Update shebangs and add script metadata comments in tools/make_changelog.py and noxfile.py
- Upgrade nox version requirements and adjust nox session decorators
- Add and remove PYBIND11_NUMPY_1_ONLY flags in CI job configurations
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/make_changelog.py | Updated shebang to use "uv run" and added metadata comments |
| noxfile.py | Updated shebang, version requirement, and modified session decorators |
| .github/workflows/ci.yml | Adjusted PYBIND11_NUMPY_1_ONLY flag usage in different CI job sections |
Files not reviewed (1)
- tests/requirements.txt: Language not supported
Comments suppressed due to low confidence (3)
noxfile.py:57
- Setting default=False for the docs session changes its default execution behavior. Verify that this is intentional, and update documentation if needed.
@nox.session(reuse_venv=True, default=False)
.github/workflows/ci.yml:69
- The removal of the -DPYBIND11_NUMPY_1_ONLY=ON flag in the first build configuration may lead to inconsistent behavior compared to other job sections. Confirm whether this change is intentional and consistent with the desired build setup.
-DPYBIND11_NUMPY_1_ONLY=ON
.github/workflows/ci.yml:69
- Similarly, the removal of the -DPYBIND11_NUMPY_1_ONLY=ON flag in the second build configuration could cause inconsistencies across builds. Please verify that this removal aligns with the intended build configuration strategy.
-DPYBIND11_NUMPY_1_ONLY=ON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update some test deps and modernize the noxfile. The
make_changelogscript now supports PEP 723 runners, so you can, for example, douv run make_changelog.pyorpipx run make_changelog.py.