Skip to content

Feature: move tests to nose2#412

Merged
mottosso merged 19 commits into
pyblish:masterfrom
moqodow:feat/move-to-nose2
Jun 17, 2026
Merged

Feature: move tests to nose2#412
mottosso merged 19 commits into
pyblish:masterfrom
moqodow:feat/move-to-nose2

Conversation

@moqodow

@moqodow moqodow commented May 28, 2026

Copy link
Copy Markdown

Hello,

as with the comment in #409 (comment) by @mottosso this PR switches the tests from nose to nose2.

Kind regards,
Wilfried

@mottosso

Copy link
Copy Markdown
Member

Ok, looks straightforward, nice work. Do you think we can make appveyor work with this as well? It would be fine to reduce the Pythons to just 1 version, and use something more recent like 3.11 or 3.12

This is what you'd need to edit:

@moqodow

moqodow commented May 28, 2026

Copy link
Copy Markdown
Author

Ok, looks straightforward, nice work. Do you think we can make appveyor work with this as well? It would be fine to reduce the Pythons to just 1 version, and use something more recent like 3.11 or 3.12

This is what you'd need to edit:

* https://github.com/pyblish/pyblish-base/blob/master/appveyor.yml

Ok. Thanks, missed this file. Will look into it and change it.

@moqodow

moqodow commented May 28, 2026

Copy link
Copy Markdown
Author

Ok, looks straightforward, nice work. Do you think we can make appveyor work with this as well? It would be fine to reduce the Pythons to just 1 version, and use something more recent like 3.11 or 3.12
This is what you'd need to edit:

* https://github.com/pyblish/pyblish-base/blob/master/appveyor.yml

Ok. Thanks, missed this file. Will look into it and change it.

@mottosso I updated appvoyer but added python version 3.8 to 3.14.

The free threaded python versions are not added but work as I'm tested them locally.

@mottosso

Copy link
Copy Markdown
Member

Looks like some builds pick up an older Python, as if pip.exe is coming from Python 2 rather than the one from the environment.

And how come there are only 178 tests running, compared to 193 from before?

@moqodow
moqodow force-pushed the feat/move-to-nose2 branch 11 times, most recently from c5e8e12 to 055b7a7 Compare June 1, 2026 18:04
@moqodow
moqodow force-pushed the feat/move-to-nose2 branch 16 times, most recently from cd52a33 to e60434a Compare June 2, 2026 17:05
@moqodow
moqodow force-pushed the feat/move-to-nose2 branch from e60434a to 151a858 Compare June 2, 2026 17:32
Moqodow added 2 commits June 2, 2026 19:39
The image includes python-2.7 by default which causes some errors
when running tests.

This fix removes any python version in the Path env before adding
the required python version for the test.
@moqodow
moqodow force-pushed the feat/move-to-nose2 branch from 151a858 to 3240e06 Compare June 2, 2026 17:41
Moqodow added 2 commits June 8, 2026 14:10
The previous approach doesn't use the pathlib.Path object as it would
be used by a consumer of the framework. Therefore the tests are always
failing on Linux even if the path is correctly registered.
@mottosso

mottosso commented Jun 9, 2026

Copy link
Copy Markdown
Member

It's starting to smell like vibe coding and I'm cautious about spending much time to review this.

@moqodow

moqodow commented Jun 9, 2026

Copy link
Copy Markdown
Author

It's starting to smell like vibe coding and I'm cautious about spending much time to review this.

Hello @mottosso,

I'm not using any LLM or the like. I'm not a fan of them either. I just try to get the test to run on both Linux and Windows without changing them. As I don't have a Windows PC, I have to rely on the CI to see if the change does not introduce a regression. I did change the commit in place and force pushed for testing purpose only. After the testing I did do a rebase to clean up the chaotic commits.
I didn't follow up on your last comment till now as I still wanted to look into something.

The missing tests from last time where the doc tests. I didn't configure them correctly in nose2 config.
Also python2 is always included in the default CI image of appveyor. I don't know the reason why it was picked up sometimes. I had not change anything.
The mock library is included in python unittest since version 3.3 therefore changed the test to use it.
Also the change to uv run is to avoid the environment picking up old vendored mock libraries that should not be present in the build environment.

If there is a way to have a complete clean environment for each time, please point me to the documentation, I could not find any relevant reference.

Out of curiosity, what did give the impression that this is vibe coded?

Kind regards,
Wilfried

@mottosso

Copy link
Copy Markdown
Member

Ok, I think this looks good and proper. There are a lot of edits, which makes any PR hard to review. But the edits appear mostly identical across many files and I can't spot anything off. Great work.

@mottosso
mottosso merged commit f6c1db6 into pyblish:master Jun 17, 2026
1 check passed
@moqodow
moqodow deleted the feat/move-to-nose2 branch June 17, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants